Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large UX updates, replaced banner, moved analytics, linted everything #20004

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Large UX updates, replaced banner, moved analytics, linted everything #20004

merged 6 commits into from
Mar 21, 2024

Conversation

MaanavD
Copy link
Contributor

@MaanavD MaanavD commented Mar 20, 2024

https://maanavd.github.io/onnxruntime/

Description

Many changes, most small, but quite a few. Listed here:

  • Infinitely scrolling testimonial banner on homepage
  • New Microsoft-approved cookie consent banner (only shows up in correct regions, here's a screen of it working): image You can duplicate this behavior if you want using: this link
  • removed SAOS animations, relying on native tailwind animations
  • ran a linting pass
  • easter egg for hovering onnxruntime pinwheel

@sophies927
Copy link
Contributor

Looks like the customer survey pop-up shows behind the infinite scroll testimonial banner if you zoom in a bit / have a smaller screen (you can see it in the bottom right corner of the screenshot you shared) - would probably by best to have it in front of the banner instead.

@MaanavD MaanavD merged commit e8b82b6 into microsoft:gh-pages Mar 21, 2024
7 checks passed
@MaanavD MaanavD deleted the misc_ui_fixes branch March 21, 2024 21:40
sophies927
sophies927 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@sophies927 sophies927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophies927 sophies927 sophies927 approved these changes

@natke natke natke approved these changes

@prasanthpul prasanthpul Awaiting requested review from prasanthpul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaanavD @sophies927 @natke